Changeset tfkyle@gmail.com-20070321045932-a6awecmgz2bpveer

Timestamp:

03/21/07 04:59:32 (3 years ago)

Author:

Kyle McFarland <tfkyle@…>

branch-nick:

snakeoil

Message:

different approach to stop compiling other modules, use build_ext and a custom OptionalExtension? class instead of overriding build (would have to override install too in that case it seems)

Files:

• setup.cfg (modified) (1 diff)
• setup.py (modified) (5 diffs)

setup.cfg

@@ -1 @@
-[build]
+[build_ext]
 # uncomment if you don't want to build the extension modules
-#build-c=false
+#build-optional=false

setup.py

@@ -8 +8 @@
 
 from distutils import core, ccompiler, log, errors
-from distutils.command import build, sdist, build_py, build_scripts, install, build
+from distutils.command import build, sdist, build_ext, build_py, build_scripts, install
 from stat import ST_MODE
+
+class OptionalExtension(core.Extension):
+        pass
 
 if os.name == "nt":
@@ -108 +111 @@
                 self.byte_compile([bzr_ver])
 
-class snakeoil_build(build.build):
-
-    user_options = build.build.user_options + [
-        ("build-c=", "o", "build optional C modules for extra speed"),
+class snakeoil_build_ext(build_ext.build_ext):
+
+    user_options = build_ext.build_ext.user_options + [
+        ("build-optional=", "o", "build optional C modules"),
     ]
 
-    boolean_options = build.build.boolean_options + ["build-c"]
+    boolean_options = build.build.boolean_options + ["build-optional"]
 
     def initialize_options(self):
-        build.build.initialize_options(self)
-        self.build_c = None
+        build_ext.build_ext.initialize_options(self)
+        self.build_optional = None
 
     def finalize_options(self):
-        build.build.finalize_options(self)
-        if self.build_c is None:
-            self.build_c = True
-
-    def has_ext_modules(self):
-        return bool(self.build_c) and build.build.has_ext_modules(self)
-
-    sub_commands = [(name, pre) for name, pre in build.build.sub_commands if name != "build_ext"]
-    sub_commands += [("build_ext", has_ext_modules)]
+        build_ext.build_ext.finalize_options(self)
+        if self.build_optional is None:
+            self.build_optional = True
+
+    def build_extension(self, ext):
+                if isinstance(ext, OptionalExtension) and not self.build_optional:
+                        return
+                build_ext.build_ext.build_extension(self, ext)
 
 class TestLoader(unittest.TestLoader):
@@ -203 +205 @@
 if sys.version_info < (2, 5):
     # Almost unmodified copy from the python 2.5 source.
-    extensions.append(core.Extension(
+    extensions.append(OptionalExtension(
             'snakeoil._functools', ['src/functoolsmodule.c'],
             extra_compile_args=extra_flags, depends=common_includes))
@@ -217 +219 @@
     packages=packages,
     ext_modules=[
-        core.Extension(
+        OptionalExtension(
             'snakeoil.osutils._posix', ['src/posix.c'],
             extra_compile_args=extra_flags, depends=common_includes),
-        core.Extension(
+        OptionalExtension(
             'snakeoil._klass', ['src/klass.c'],
             extra_compile_args=extra_flags, depends=common_includes),
-        core.Extension(
+        OptionalExtension(
             'snakeoil._caching', ['src/caching.c'],
             extra_compile_args=extra_flags, depends=common_includes),
-        core.Extension(
+        OptionalExtension(
             'snakeoil._lists', ['src/lists.c'],
             extra_compile_args=extra_flags, depends=common_includes),
-        core.Extension(
+        OptionalExtension(
             'snakeoil.osutils._readdir', ['src/readdir.c'],
             extra_compile_args=extra_flags, depends=common_includes),
@@ -235 +237 @@
     cmdclass={
         'sdist': mysdist,
-        'build': snakeoil_build,
+        'build_ext': snakeoil_build_ext,
         'build_py': snakeoil_build_py,
         'test': test,